chore(releases): update minor version criterion#996
Open
marbens-arch wants to merge 1 commit intosyncthing:mainfrom
Open
chore(releases): update minor version criterion#996marbens-arch wants to merge 1 commit intosyncthing:mainfrom
marbens-arch wants to merge 1 commit intosyncthing:mainfrom
Conversation
For some time, the minor version criterion hasn't been up to date. For instance, v2.0.16-rc.1 contains a "configuration change so that a downgrade might be problematic", but is still a patch version.
Member
|
IMHO, the automation regarding version bumps from commit subjects is fine and could be documented here as well. The real problem I see is that sometimes the commits are not tagged properly, leading to a minor version not being bumped although it should have been. Semantically, I fully agree with the old definition you're removing here. In reality, that guidance wasn't always followed, but that doesn't invalidate the intention stated here in the docs. |
Member
Author
|
IMHO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some time (since syncthing/syncthing@58c85fc I think), the minor version criterion hasn't been up to date.
For instance, v2.0.16-rc.1 contains a "configuration change so that a downgrade might be problematic", but is still a patch version.
I think the version number is automatically chosen based on commit type when pushing to
releaseorrelease-rcbranch.https://github.com/syncthing/syncthing/blob/8c7c413f5cc6690865e4c9b5fabbe9227b52138c/script/next-version.go#L61-L73